Oleg Nesterov
e56fb28740
exec: do not abuse ->cred_guard_mutex in threadgroup_lock() ...
threadgroup_lock() takes signal->cred_guard_mutex to ensure that
thread_group_leader() is stable. This doesn't look nice, the scope of
this lock in do_execve() is huge.
And as Dave pointed out this can lead to deadlock, we have the
following dependencies:
do_execve: cred_guard_mutex -> i_mutex
cgroup_mount: i_mutex -> cgroup_mutex
attach_task_by_pid: cgroup_mutex -> cred_guard_mutex
Change de_thread() to take threadgroup_change_begin() around the
switch-the-leader code and change threadgroup_lock() to avoid
->cred_guard_mutex.
Note that de_thread() can't sleep with ->group_rwsem held, this can
obviously deadlock with the exiting leader if the writer is active, so it
does threadgroup_change_end() before schedule().
Reported-by: Dave Jones <davej@redhat.com>
Acked-by: Tejun Heo <tj@kernel.org>
Acked-by: Li Zefan <lizefan@huawei.com>
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2013-04-30 17:04:07 -07:00
2013-03-29 09:20:05 -07:00
2013-03-02 16:33:54 -08:00
2013-01-28 18:17:25 -05:00
2013-02-26 15:03:06 -08:00
2013-03-27 08:35:34 -07:00
2013-01-30 07:54:34 -06:00
2013-02-13 08:35:43 -08:00
2013-01-03 15:41:20 +01:00
2013-03-01 13:39:00 -08:00
2013-03-08 16:03:29 -08:00
2013-04-30 09:36:50 -07:00
2013-02-20 11:00:43 -08:00
2013-03-03 12:06:09 -08:00
2013-02-28 18:02:55 -08:00
2013-04-29 19:47:50 -07:00
2013-02-26 11:41:08 -08:00
2013-02-24 14:37:22 -05:00
2013-03-14 12:48:54 +00:00
2013-04-09 21:04:16 +02:00
2013-02-13 06:16:08 -08:00
2013-04-19 15:45:05 +02:00
2013-04-29 19:47:50 -07:00
2013-02-16 13:34:10 -08:00
2013-01-02 17:36:10 -08:00
2013-04-28 02:13:43 +01:00
2013-02-22 09:20:11 -08:00
2013-04-07 10:07:59 +01:00
2013-04-10 10:31:26 -04:00
2013-03-02 16:46:07 -08:00
2013-04-23 12:50:38 -07:00
2013-01-29 11:47:06 +01:00
2013-04-16 10:27:15 -06:00
2013-01-03 14:34:06 -08:00
2013-03-12 13:59:14 -07:00
2013-01-03 15:57:16 -08:00
2013-04-03 19:33:40 -04:00
2013-01-11 14:54:56 -08:00
2013-02-21 17:22:19 -08:00
2013-03-01 12:47:16 +01:00
2013-02-26 02:46:13 -05:00
2013-04-29 15:54:33 -07:00
2013-01-11 19:53:53 +01:00
2013-04-18 09:00:26 -07:00
2013-02-15 18:52:45 -08:00
2013-04-29 15:54:39 -07:00
2013-02-20 09:37:28 -05:00
2013-04-29 15:54:33 -07:00
2013-02-21 17:22:16 -08:00
2013-04-14 10:06:31 -07:00
2013-04-30 07:43:28 -07:00
2013-04-30 17:04:01 -07:00
2013-03-22 15:18:18 -07:00
2013-04-12 11:22:35 -07:00
2013-04-10 16:33:53 -07:00
2013-03-22 10:48:33 +01:00
2013-03-15 16:50:27 -07:00
2013-02-13 06:00:53 -08:00
2013-02-23 17:50:10 -08:00
2013-03-19 19:15:52 +01:00
2013-02-21 17:22:15 -08:00
2013-04-29 18:28:13 -07:00
2013-02-21 17:22:15 -08:00
2013-04-08 17:28:34 +02:00
2013-02-15 16:45:06 +01:00
2013-04-29 18:28:13 -07:00
2013-03-07 17:10:11 +01:00
2013-01-11 14:54:54 -08:00
2013-04-08 17:39:23 +02:00
2013-02-02 01:29:32 +01:00
2013-02-11 18:49:51 -05:00
2013-03-12 11:30:04 -07:00
2013-03-05 09:33:26 -08:00
2013-01-09 08:26:53 -08:00
2013-04-29 18:28:19 -07:00
2013-02-26 02:46:09 -05:00
2013-04-29 15:54:27 -07:00
2013-01-18 15:25:53 -08:00
2013-04-02 01:28:41 +02:00
2013-03-01 22:45:49 +00:00
2013-04-29 19:07:40 -07:00
2013-03-01 22:45:49 +00:00
2013-02-27 15:13:36 +05:30
2013-02-27 22:37:34 +05:30
2013-04-30 17:04:02 -07:00
2012-12-24 09:36:38 -07:00
2013-02-28 09:53:21 +05:30
2013-01-17 12:19:09 -08:00
2013-03-03 23:59:59 -08:00
2013-03-16 06:32:30 +01:00
2013-04-09 11:34:05 +01:00
2013-02-28 12:52:24 -08:00
2013-02-26 02:46:08 -05:00
2013-01-21 14:07:44 -05:00
2013-02-27 19:10:23 -08:00
2013-03-27 13:48:25 +01:00
2013-04-29 18:28:40 -07:00
2013-01-24 09:04:04 +01:00
2013-02-23 17:50:12 -08:00
2013-03-31 11:38:33 -07:00
2013-04-30 17:04:00 -07:00
2013-03-27 07:49:29 -07:00
2013-04-30 17:04:03 -07:00
2012-12-20 22:34:00 +00:00
2012-12-20 22:04:07 +00:00
2013-04-29 18:28:41 -07:00
2013-02-22 23:31:31 -05:00
2013-04-19 17:10:27 -04:00
2013-04-29 13:55:38 -07:00
2013-04-29 18:28:13 -07:00
2013-02-26 03:10:52 +11:00
2012-12-18 15:02:12 -08:00
2013-01-22 10:23:35 +01:00
2013-02-22 00:05:07 +01:00
2013-03-18 10:21:23 +01:00
2013-02-27 19:10:24 -08:00
2013-02-22 08:20:05 +01:00
2013-04-30 10:09:06 +02:00
2013-01-06 11:48:11 +00:00
2013-01-06 11:41:12 +00:00
2013-04-30 10:17:48 +02:00
2013-02-23 17:50:16 -08:00
2013-03-22 16:19:59 -07:00
2013-04-29 15:54:38 -07:00
2012-12-18 15:02:15 -08:00
2013-04-29 15:54:35 -07:00
2013-01-25 21:03:54 -08:00
2013-04-29 15:54:26 -07:00
2013-04-29 18:28:41 -07:00
2013-02-15 09:41:42 +01:00
2013-02-06 15:59:47 -05:00
2013-02-27 19:10:24 -08:00
2013-02-23 21:00:06 -05:00
2013-03-27 13:48:25 +01:00
2013-02-11 14:16:26 -05:00
2013-01-29 13:59:57 -05:00
2013-02-19 08:06:01 +01:00
2013-01-23 09:31:01 -08:00
2013-03-27 13:48:25 +01:00
2013-01-11 14:54:54 -08:00
2013-02-06 10:47:28 +01:00
2013-04-29 15:54:37 -07:00
2013-03-15 12:23:09 -07:00
2013-01-04 16:11:45 -08:00
2013-02-27 19:10:21 -08:00
2013-01-30 22:41:13 -05:00
2013-03-22 16:41:19 -07:00
2013-01-28 12:17:25 +01:00
2013-01-10 11:44:38 -06:00
2013-02-09 16:29:20 -05:00
2013-03-22 16:20:00 -07:00
2013-01-27 19:23:27 +01:00
2013-04-30 17:04:03 -07:00
2013-04-17 12:35:33 -07:00
2013-02-04 15:35:26 -08:00
2013-04-30 17:04:06 -07:00
2013-04-08 17:28:34 +02:00
2013-02-23 17:50:19 -08:00
2013-04-30 17:04:02 -07:00
2013-04-07 13:05:35 +03:00
2013-04-07 13:05:35 +03:00
2013-02-01 17:47:04 -08:00
2013-04-03 19:33:43 -04:00
2013-01-06 01:11:25 -08:00
2013-03-12 14:07:41 -07:00
2013-03-14 13:18:30 -07:00
2013-02-19 15:17:08 -05:00
2013-02-22 19:25:09 -08:00
2013-02-20 19:36:01 +01:00
2013-02-02 00:01:15 +01:00
2013-03-13 18:03:27 +01:00
2013-04-08 16:57:15 -07:00
2013-03-02 09:34:39 -08:00
2013-02-23 17:50:20 -08:00
2013-04-29 15:54:37 -07:00
2013-04-30 17:04:00 -07:00
2013-01-02 17:32:13 -08:00
2013-01-28 18:42:10 -05:00
2013-02-23 17:50:19 -08:00
2013-02-23 17:50:17 -08:00
2013-04-29 15:54:36 -07:00
2013-03-28 17:45:51 -07:00
2013-02-05 20:38:48 +11:00
2013-04-30 09:36:50 -07:00
2013-03-29 08:35:47 -07:00
2013-01-21 17:18:20 +10:30
2013-03-27 07:50:04 -07:00
2013-01-21 13:55:14 -05:00
2013-01-21 13:55:14 -05:00
2013-01-04 16:11:45 -08:00
2013-04-23 09:50:30 -06:00
2013-04-19 09:33:36 +02:00
2013-03-19 11:07:58 +08:00
2012-12-25 18:45:06 -05:00
2013-04-29 18:28:44 -07:00
2013-02-15 15:17:11 -05:00
2013-04-05 00:18:46 -04:00
2013-02-11 19:19:33 -05:00
2013-02-13 06:16:06 -08:00
2013-02-13 06:15:29 -08:00
2013-03-02 16:46:07 -08:00
2013-04-29 15:54:36 -07:00
2013-01-17 19:11:14 -08:00
2013-01-07 22:05:02 -08:00
2013-02-13 10:11:53 +00:00
2012-12-19 16:15:17 +00:00
2013-02-13 10:09:31 +00:00
2013-02-23 00:30:08 +01:00
2013-02-23 17:50:17 -08:00
2013-02-14 15:55:23 +01:00
2013-02-23 17:50:15 -08:00
2013-04-29 15:54:28 -07:00
2013-03-01 23:51:07 -05:00
2013-04-17 10:21:17 -06:00
2013-04-30 08:42:45 -07:00
2013-04-12 16:52:01 -06:00
2013-04-17 10:21:17 -06:00
2013-04-17 10:21:17 -06:00
2013-04-29 09:30:25 -07:00
2013-04-17 10:21:17 -06:00
2013-02-05 11:54:06 +01:00
2013-04-08 11:43:30 +02:00
2013-01-14 15:11:50 -05:00
2012-12-25 16:10:05 -08:00
2013-02-27 19:10:24 -08:00
2013-03-29 09:14:16 -07:00
2013-01-23 14:39:19 +00:00
2013-02-23 17:50:16 -08:00
2013-02-23 17:50:16 -08:00
2013-04-17 20:51:01 +02:00
2013-02-21 12:05:51 -08:00
2013-02-13 09:40:35 -08:00
2013-04-09 10:48:33 -07:00
2013-04-30 17:04:02 -07:00
2013-04-09 14:09:17 -04:00
2013-01-24 15:37:26 +01:00
2013-01-03 15:57:14 -08:00
2013-01-11 10:20:50 -08:00
2013-01-20 12:26:05 -08:00
2013-02-26 09:34:29 -08:00
2013-02-08 13:14:40 +00:00
2013-01-24 23:24:56 -05:00
2013-04-29 15:54:28 -07:00
2013-01-23 13:44:00 -05:00
2013-01-11 14:54:56 -08:00
2013-03-12 14:07:41 -07:00
2013-02-27 19:10:24 -08:00
2013-03-26 08:04:51 -07:00
2013-03-27 13:03:39 +00:00
2013-04-29 19:14:20 -07:00
2013-03-15 00:34:50 -04:00
2013-02-23 17:50:17 -08:00
2013-04-29 18:28:22 -07:00
2013-01-16 12:13:20 -08:00
2013-02-27 19:10:10 -08:00
2013-04-30 17:04:07 -07:00
2013-04-10 15:40:39 -04:00
2013-02-19 08:43:34 +01:00
2013-01-15 23:03:00 -08:00
2013-02-13 10:13:58 -08:00
2013-04-11 13:14:36 -07:00
2013-03-19 19:15:52 +01:00
2013-04-05 15:38:10 -04:00
2012-12-18 15:02:13 -08:00
2012-12-18 15:02:14 -08:00
2012-12-18 15:02:14 -08:00
2013-04-30 17:04:03 -07:00
2013-02-26 22:25:17 +01:00
2013-02-10 19:41:08 -05:00
2013-04-09 10:48:33 -07:00
2013-02-07 15:15:00 -08:00
2013-03-25 10:39:40 -07:00
2013-03-01 12:40:36 +01:00
2013-04-30 17:04:03 -07:00
2013-02-13 12:15:50 -08:00
2012-12-24 09:36:38 -07:00
2013-02-09 22:30:44 +01:00
2013-04-29 15:54:38 -07:00
2013-04-17 12:35:32 -07:00
2013-02-14 09:21:15 -05:00
2013-01-25 21:51:13 +01:00
2013-02-13 13:22:15 -05:00
2013-01-28 11:19:06 -07:00
2013-03-20 17:56:58 -04:00
2012-12-18 15:02:13 -08:00
2013-02-05 00:48:46 +01:00
2013-03-22 16:19:59 -07:00
2013-04-04 13:18:31 -07:00
2013-04-04 13:18:14 -07:00
2013-03-15 00:36:09 -04:00
2013-01-27 19:23:31 +01:00
2013-02-04 15:40:28 -08:00
2013-01-15 22:43:15 -08:00
2013-03-18 16:14:55 -07:00
2013-03-18 16:44:02 -07:00
2013-04-15 21:23:03 +01:00
2013-03-20 12:10:38 -04:00
2013-04-13 15:31:58 +02:00
2013-03-28 11:10:22 -07:00
2013-03-27 07:50:08 -07:00
2013-02-14 00:22:58 +01:00
2013-02-13 17:00:32 +10:30
2013-02-23 17:50:15 -08:00
2013-04-29 15:54:34 -07:00
2013-04-29 15:54:38 -07:00
2013-04-29 15:54:37 -07:00
2013-01-08 16:15:57 -08:00
2013-01-08 16:15:57 -08:00
2013-02-08 12:13:43 +10:00
2013-01-27 20:35:47 +01:00
2013-01-31 19:56:35 -05:00
2013-03-01 12:48:36 +01:00
2013-02-08 10:05:02 +02:00
2013-04-30 17:04:02 -07:00
2013-01-12 10:47:43 +08:00
e56fb28740