Hugh Dickins 487e9bf25c fix tmpfs BUG and AOP_WRITEPAGE_ACTIVATE
It's possible to provoke unionfs (not yet in mainline, though in mm and
some distros) to hit shmem_writepage's BUG_ON(page_mapped(page)).  I expect
it's possible to provoke the 2.6.23 ecryptfs in the same way (but the
2.6.24 ecryptfs no longer calls lower level's ->writepage).

This came to light with the recent find that AOP_WRITEPAGE_ACTIVATE could
leak from tmpfs via write_cache_pages and unionfs to userspace.  There's
already a fix (e423003028183df54f039dfda8b58c49e78c89d7 - writeback: don't
propagate AOP_WRITEPAGE_ACTIVATE) in the tree for that, and it's okay so
far as it goes; but insufficient because it doesn't address the underlying
issue, that shmem_writepage expects to be called only by vmscan (relying on
backing_dev_info capabilities to prevent the normal writeback path from
ever approaching it).

That's an increasingly fragile assumption, and ramdisk_writepage (the other
source of AOP_WRITEPAGE_ACTIVATEs) is already careful to check
wbc->for_reclaim before returning it.  Make the same check in
shmem_writepage, thereby sidestepping the page_mapped BUG also.

Signed-off-by: Hugh Dickins <hugh@veritas.com>
Cc: Erez Zadok <ezk@cs.sunysb.edu>
Cc: <stable@kernel.org>
Reviewed-by: Pekka Enberg <penberg@cs.helsinki.fi>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2007-10-30 08:06:55 -07:00
..
2007-10-17 08:42:45 -07:00
2007-10-16 09:42:54 -07:00
2007-10-29 11:33:06 +01:00
2007-07-17 10:22:59 -07:00
2007-10-20 01:27:18 +02:00
2007-10-20 02:46:58 +02:00
2007-10-16 09:43:02 -07:00
2007-10-20 01:27:18 +02:00
2007-10-20 01:27:18 +02:00
2007-10-20 02:13:26 +02:00
2007-02-15 09:57:03 -08:00
2007-10-23 08:32:06 -07:00
2007-10-18 14:37:31 -07:00
2007-05-21 09:18:19 -07:00
2007-10-29 07:53:26 -07:00
2007-10-20 15:04:06 -07:00
2007-10-20 01:27:18 +02:00
2007-10-16 09:43:02 -07:00
2007-10-20 01:27:18 +02:00
2007-10-20 01:27:18 +02:00
2007-05-07 12:12:54 -07:00
2007-10-17 08:42:45 -07:00
2007-10-20 01:27:18 +02:00
2007-10-29 07:41:32 -07:00
2007-10-20 01:27:18 +02:00
2007-10-17 08:42:55 -07:00
2007-10-20 01:27:18 +02:00
2007-10-20 01:27:18 +02:00