Herbert Xu 9fbe87fc25 lib/mpi: Fix karactx leak in mpi_powm ...

commit c8ea9fce2baf7b643384f36f29e4194fa40d33a6 upstream.

Sometimes mpi_powm will leak karactx because a memory allocation
failure causes a bail-out that skips the freeing of karactx.  This
patch moves the freeing of karactx to the end of the function like
everything else so that it can't be skipped.

Reported-by: syzbot+f7baccc38dcc1e094e77@syzkaller.appspotmail.com
Fixes: cdec9cb5167a ("crypto: GnuPG based MPI lib - source files...")
Cc: <stable@vger.kernel.org>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Reviewed-by: Eric Biggers <ebiggers@kernel.org>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

2019-07-10 09:54:40 +02:00

..

generic_mpih-add1.c

…

generic_mpih-lshift.c

…

generic_mpih-mul1.c

…

generic_mpih-mul2.c

…

generic_mpih-mul3.c

…

generic_mpih-rshift.c

…

generic_mpih-sub1.c

…

longlong.h

lib/mpi: Fix umul_ppmm() for MIPS64r6

2018-03-03 10:24:29 +01:00

Makefile

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

mpi-bit.c

MPILIB: Provide count_leading/trailing_zeros() based on arch functions

2012-10-08 13:50:11 +10:30

mpi-cmp.c

MPILIB: Fix comparison of negative MPIs

2015-01-14 16:10:12 +00:00

mpi-inline.h

lib/mpi: use "static inline" instead of "extern inline"

2016-02-28 03:26:34 +08:00

mpi-internal.h

lib/mpi: use "static inline" instead of "extern inline"

2016-02-28 03:26:34 +08:00

mpi-pow.c

lib/mpi: Fix karactx leak in mpi_powm

2019-07-10 09:54:40 +02:00

mpicoder.c

lib/mpi: kunmap after finishing accessing buffer

2017-08-22 14:45:01 +08:00

mpih-cmp.c

…

mpih-div.c

Remove unused code from MPI library

2012-05-26 11:51:03 +10:00

mpih-mul.c

Remove unused code from MPI library

2012-05-26 11:51:03 +10:00

mpiutil.c

MPILIB: add mpi_read_buf() and mpi_get_size() helpers

2015-06-16 14:35:06 +08:00