Ard Biesheuvel
fde4c844a5
crypto: ecdh - avoid buffer overflow in ecdh_set_secret() ...
commit 0aa171e9b267ce7c52d3a3df7bc9c1fc0203dec5 upstream.
Pavel reports that commit 17858b140bf4 ("crypto: ecdh - avoid unaligned
accesses in ecdh_set_secret()") fixes one problem but introduces another:
the unconditional memcpy() introduced by that commit may overflow the
target buffer if the source data is invalid, which could be the result of
intentional tampering.
So check params.key_size explicitly against the size of the target buffer
before validating the key further.
Fixes: 17858b140bf4 ("crypto: ecdh - avoid unaligned accesses in ecdh_set_secret()")
Reported-by: Pavel Machek <pavel@denx.de>
Cc: <stable@vger.kernel.org>
Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-01-12 20:09:09 +01:00
2019-07-31 07:28:31 +02:00
2017-11-02 11:10:55 +01:00
2016-10-25 11:08:33 +08:00
2016-06-23 18:29:53 +08:00
2018-10-03 17:00:45 -07:00
2017-04-21 20:30:50 +08:00
2017-01-13 00:24:39 +08:00
2017-02-11 17:50:43 +08:00
2019-02-12 19:45:57 +01:00
2020-12-29 13:46:50 +01:00
2019-03-23 14:35:18 +01:00
2017-01-13 00:24:39 +08:00
2020-02-14 16:32:14 -05:00
2020-06-25 15:42:01 +02:00
2020-10-29 09:07:00 +01:00
2020-07-09 09:36:30 +02:00
2020-10-29 09:07:01 +01:00
2020-02-14 16:32:14 -05:00
2019-01-23 08:09:48 +01:00
2019-01-23 08:09:47 +01:00
2018-10-03 17:00:45 -07:00
2017-03-09 18:34:39 +08:00
2019-05-21 18:50:20 +02:00
2017-08-22 14:45:47 +08:00
2019-07-31 07:28:35 +02:00
2016-10-21 11:03:42 +08:00
2017-02-11 17:52:28 +08:00
2016-10-21 11:03:42 +08:00
2018-02-16 20:23:00 +01:00
2018-02-16 20:23:00 +01:00
2019-05-21 18:50:15 +02:00
2019-07-10 09:54:38 +02:00
2017-06-19 14:19:54 +08:00
2016-07-18 17:35:44 +08:00
2019-12-17 20:38:55 +01:00
2017-08-04 09:27:15 +08:00
2017-02-11 17:52:28 +08:00
2017-04-24 18:11:08 +08:00
2017-11-21 09:49:21 +01:00
2017-11-21 09:49:20 +01:00
2018-05-01 12:58:23 -07:00
2017-11-02 11:10:55 +01:00
2019-12-17 20:38:55 +01:00
2017-06-10 12:04:35 +08:00
2017-06-10 12:04:25 +08:00
2021-01-12 20:09:09 +01:00
2016-09-13 18:44:57 +08:00
2019-05-21 18:50:15 +02:00
2017-04-05 21:58:35 +08:00
2019-07-31 07:28:35 +02:00
2015-12-20 15:27:12 +02:00
2017-12-20 10:10:17 +01:00
2020-02-14 16:32:14 -05:00
2016-11-17 23:34:52 +08:00
2019-02-12 19:45:57 +01:00
2016-02-01 22:27:05 +08:00
2017-01-13 00:24:39 +08:00
2020-05-20 08:17:11 +02:00
2017-04-10 19:17:27 +08:00
2017-04-10 19:17:27 +08:00
2017-05-08 17:15:13 -07:00
2018-09-19 22:43:37 +02:00
2018-02-16 20:23:00 +01:00
2017-03-24 22:02:56 +08:00
2019-03-23 14:35:21 +01:00
2020-02-14 16:32:14 -05:00
2018-02-16 20:23:00 +01:00
2017-11-02 11:10:55 +01:00
2017-07-28 17:56:00 +08:00
2017-12-20 10:10:17 +01:00
2019-11-20 18:00:47 +01:00
2017-06-10 12:04:30 +08:00
2016-07-05 23:05:26 +08:00
2015-10-14 22:23:16 +08:00
2019-05-21 18:50:19 +02:00
2016-11-22 15:02:25 +08:00
2017-08-03 13:52:44 +08:00
2017-02-11 17:52:28 +08:00
2019-07-31 07:28:30 +02:00
2015-12-22 20:43:35 +08:00
2018-02-03 17:38:51 +01:00
2015-12-22 20:43:35 +08:00
2019-03-23 14:35:18 +01:00
2018-12-01 09:42:53 +01:00
2019-10-11 18:18:32 +02:00
2018-11-13 11:15:07 -08:00
2019-03-23 14:35:18 +01:00
2019-04-27 09:35:37 +02:00
2020-01-27 14:46:13 +01:00
2018-08-17 21:01:10 +02:00
2018-02-22 15:42:23 +01:00
2020-05-20 08:17:11 +02:00
fde4c844a5