David Howells
b4cf1e08c8
CacheFiles: Add missing retrieval completions
CacheFiles is missing some calls to fscache_retrieval_complete() in the error
handling/collision paths of its reader functions.
This can be seen by the following assertion tripping in fscache_put_operation()
whereby the operation being destroyed is still in the in-progress state and has
not been cancelled or completed:
FS-Cache: Assertion failed
3 == 5 is false
------------[ cut here ]------------
kernel BUG at fs/fscache/operation.c:408!
invalid opcode: 0000 [#1] SMP
CPU 2
Modules linked in: xfs ioatdma dca loop joydev evdev
psmouse dcdbas pcspkr serio_raw i5000_edac edac_core i5k_amb shpchp
pci_hotplug sg sr_mod]
Pid: 8062, comm: httpd Not tainted 3.1.0-rc8 #1 Dell Inc. PowerEdge 1950/0DT097
RIP: 0010:[<ffffffff81197b24>] [<ffffffff81197b24>] fscache_put_operation+0x304/0x330
RSP: 0018:ffff880062f739d8 EFLAGS: 00010296
RAX: 0000000000000025 RBX: ffff8800c5122e84 RCX: ffffffff81ddf040
RDX: 00000000ffffffff RSI: 0000000000000082 RDI: ffffffff81ddef30
RBP: ffff880062f739f8 R08: 0000000000000005 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000003 R12: ffff8800c5122e40
R13: ffff880037a2cd20 R14: ffff880087c7a058 R15: ffff880087c7a000
FS: 00007f63dcf636e0(0000) GS:ffff88022fc80000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00007f0c0a91f000 CR3: 0000000062ec2000 CR4: 00000000000006e0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400
Process httpd (pid: 8062, threadinfo ffff880062f72000, task ffff880087e58000)
Stack:
ffff880062f73bf8 0000000000000000 ffff880062f73bf8 ffff880037a2cd20
ffff880062f73a68 ffffffff8119aa7e ffff88006540e000 ffff880062f73ad4
ffff88008e9a4308 ffff880037a2cd20 ffff880062f73a48 ffff8800c5122e40
Call Trace:
[<ffffffff8119aa7e>] __fscache_read_or_alloc_pages+0x1fe/0x530
[<ffffffff81250780>] __nfs_readpages_from_fscache+0x70/0x1c0
[<ffffffff8123142a>] nfs_readpages+0xca/0x1e0
[<ffffffff815f3c06>] ? rpc_do_put_task+0x36/0x50
[<ffffffff8122755b>] ? alloc_nfs_open_context+0x4b/0x110
[<ffffffff815ecd1a>] ? rpc_call_sync+0x5a/0x70
[<ffffffff810e7e9a>] __do_page_cache_readahead+0x1ca/0x270
[<ffffffff810e7f61>] ra_submit+0x21/0x30
[<ffffffff810e818d>] ondemand_readahead+0x11d/0x250
[<ffffffff810e83b6>] page_cache_sync_readahead+0x36/0x60
[<ffffffff810dffa4>] generic_file_aio_read+0x454/0x770
[<ffffffff81224ce1>] nfs_file_read+0xe1/0x130
[<ffffffff81121bd9>] do_sync_read+0xd9/0x120
[<ffffffff8114088f>] ? mntput+0x1f/0x40
[<ffffffff811238cb>] ? fput+0x1cb/0x260
[<ffffffff81122938>] vfs_read+0xc8/0x180
[<ffffffff81122af5>] sys_read+0x55/0x90
Reported-by: Mark Moseley <moseleymark@gmail.com>
Signed-off-by: David Howells <dhowells@redhat.com>
2012-12-20 22:07:40 +00:00
..
2012-10-12 09:59:23 +09:00
2012-10-02 20:25:04 -07:00
2012-10-02 20:25:04 -07:00
2012-10-02 20:25:04 -07:00
2012-12-17 15:44:47 -08:00
2012-10-02 20:25:04 -07:00
2012-10-02 20:25:04 -07:00
2012-12-18 09:42:05 -08:00
2012-12-20 22:07:40 +00:00
2012-12-18 15:02:11 -08:00
2012-12-17 17:15:12 -08:00
2012-10-02 21:35:55 -04:00
2012-12-17 17:15:12 -08:00
2012-09-21 03:13:08 -07:00
2012-11-15 17:46:42 -08:00
2012-10-22 16:50:13 -07:00
2012-11-16 11:20:42 -06:00
2012-10-02 20:25:04 -07:00
2012-10-02 20:25:04 -07:00
2012-12-14 12:17:32 +02:00
2012-12-17 17:15:27 -08:00
2012-10-09 23:23:53 +02:00
2012-12-17 17:15:12 -08:00
2012-12-17 17:15:12 -08:00
2012-12-17 17:15:22 -08:00
2012-10-02 20:25:04 -07:00
2012-12-20 22:07:40 +00:00
2012-12-17 20:58:12 -08:00
2012-12-17 17:15:12 -08:00
2012-10-02 20:25:04 -07:00
2012-10-02 20:25:04 -07:00
2012-10-10 11:15:20 +09:00
2012-10-09 23:33:38 -04:00
2012-11-19 05:59:09 -08:00
2012-12-13 12:00:02 -08:00
2012-10-09 23:33:55 -04:00
2012-12-13 12:00:02 -08:00
2012-12-16 17:33:01 -08:00
2012-11-18 11:59:01 +02:00
2012-10-17 09:18:38 -05:00
2012-11-04 14:43:40 -05:00
2012-11-19 14:31:35 +01:00
2012-10-02 20:25:04 -07:00
2012-12-06 10:39:54 +01:00
2012-12-20 22:06:33 +00:00
2012-10-09 18:35:22 -04:00
2012-12-11 17:22:26 -08:00
2012-06-01 19:51:22 -07:00
2012-12-17 17:15:28 -08:00
2012-10-02 20:25:04 -07:00
2012-12-17 17:15:12 -08:00
2012-10-06 03:05:31 +09:00
2012-10-02 21:35:55 -04:00
2012-12-17 20:58:12 -08:00
2012-12-17 17:15:12 -08:00
2012-10-02 20:25:04 -07:00
2012-10-02 20:25:04 -07:00
2012-12-13 16:33:24 +01:00
2012-07-14 16:34:47 +04:00
2012-11-19 21:34:33 +01:00
2012-10-02 21:35:55 -04:00
2012-10-02 20:25:04 -07:00
2012-12-17 15:44:47 -08:00
2012-10-09 23:33:39 -04:00
2012-12-17 17:15:26 -08:00
2012-12-13 16:33:23 +01:00
2012-10-09 23:33:39 -04:00
2012-12-03 12:10:59 -06:00
2012-07-22 23:57:59 +04:00
2012-11-20 04:17:24 -08:00
2012-12-17 17:15:12 -08:00
2012-11-28 21:53:38 -05:00
2012-11-28 21:53:38 -05:00
2012-12-17 17:15:19 -08:00
2012-12-17 17:15:23 -08:00
2012-11-28 21:53:38 -05:00
2012-12-17 17:15:23 -08:00
2012-12-17 17:15:23 -08:00
2012-11-28 21:53:38 -05:00
2012-09-09 10:35:38 +02:00
2012-10-22 22:00:26 +02:00
2012-12-17 17:15:12 -08:00
2012-12-12 17:38:35 -08:00
2012-10-22 08:50:37 +03:00
2012-10-06 03:05:17 +09:00
2012-10-29 09:00:57 -07:00
2012-10-12 20:14:55 -04:00
2012-11-29 00:01:25 -05:00
2012-10-06 03:05:15 +09:00
2012-10-02 20:25:04 -07:00
2012-11-29 12:38:44 -08:00
2012-12-17 17:15:27 -08:00
2012-12-17 17:15:27 -08:00
2012-12-17 20:58:12 -08:00
2012-10-09 15:52:31 +09:00
2012-11-19 14:31:35 +01:00
2012-07-16 08:33:14 -07:00
2012-10-10 01:15:44 -04:00
2012-12-12 12:22:13 -08:00
2012-10-12 20:14:55 -04:00
2012-11-28 21:49:02 -05:00
2012-12-12 17:38:34 -08:00
2012-09-18 01:01:35 -07:00
2012-12-11 17:22:26 -08:00
2012-11-26 17:41:24 -08:00
2012-09-26 22:20:08 -04:00
2012-12-10 16:30:43 -05:00
2012-10-06 03:05:15 +09:00
2012-12-17 17:15:12 -08:00
2012-10-09 18:35:22 -04:00
2012-10-06 03:05:15 +09:00
2012-11-20 04:19:49 -08:00
2012-11-29 22:17:21 -05:00
2012-12-14 16:12:03 -08:00
2012-12-20 22:05:41 +00:00
2012-09-26 21:08:52 -04:00
2012-07-14 16:37:27 +04:00
2012-11-19 05:59:20 -08:00
2012-09-18 01:01:35 -07:00
2012-07-14 16:32:48 +04:00
2012-12-17 17:15:12 -08:00
2012-10-02 21:35:55 -04:00
2012-09-26 22:20:08 -04:00
2012-09-26 22:20:08 -04:00
2012-12-17 17:15:12 -08:00
2012-12-17 17:15:27 -08:00
2012-12-11 17:22:21 -08:00
2012-10-02 20:25:04 -07:00
2012-09-26 22:20:08 -04:00
2012-10-09 23:33:39 -04:00
2012-09-26 22:20:08 -04:00
2012-09-26 22:20:08 -04:00
2012-09-26 22:20:08 -04:00
2012-10-12 13:16:48 -07:00
2012-10-18 12:35:58 -07:00