Mika Westerberg b5539fa2d5 gpio / ACPI: Prevent potential wrap of GPIO value on OpRegion read
Dan Carpenter's static code checker reports:

 The patch 473ed7be0da0: "gpio / ACPI: Add support for ACPI GPIO
 operation regions" from Mar 14, 2014, leads to the following static
 checker warning:

  drivers/gpio/gpiolib-acpi.c:454 acpi_gpio_adr_space_handler()
  warn: should 'gpiod_get_raw_value(desc) << i' be a 64 bit type?

This is due the fact that *value is of type u64 and gpiod_get_raw_value()
returns int. Since i can be larger than 31, it is possible that the value
returned gets wrapped.

Fix this by casting the return of gpiod_get_raw_value() to u64 first before
shift.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
2014-04-14 10:22:36 +02:00
..
2013-10-29 18:26:14 -07:00
2013-12-12 14:28:12 +01:00
2014-03-14 10:26:45 +01:00
2012-11-28 11:39:59 -08:00
2013-08-16 15:24:35 +02:00
2012-11-28 11:39:33 -08:00
2014-01-21 10:09:12 -08:00
2013-08-16 15:24:35 +02:00
2013-08-16 15:24:35 +02:00
2013-12-09 14:04:37 +01:00
2013-06-17 07:47:33 +02:00
2014-04-05 15:37:40 -07:00
2014-03-18 09:28:31 +01:00