Colin Ian King d7867fbbd4 ALSA: cs4236: fix error return comparison of an unsigned integer ...

commit d60229d84846a8399257006af9c5444599f64361 upstream.

The return from pnp_irq is an unsigned integer type resource_size_t
and hence the error check for a positive non-error code is always
going to be true.  A check for a non-failure return from pnp_irq
should in fact be for (resource_size_t)-1 rather than >= 0.

Addresses-Coverity: ("Unsigned compared against 0")
Fixes: a9824c868a2c ("[ALSA] Add CS4232 PnP BIOS support")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Link: https://lore.kernel.org/r/20191122131354.58042-1-colin.king@canonical.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

2020-01-09 10:17:56 +01:00

..

cs4231.c

ALSA: cs423x: fix format string overflow warning

2017-07-18 17:51:55 +02:00

cs4236_lib.c

ALSA: cs423x: Constify hw_constraints

2017-06-09 10:42:46 +02:00

cs4236.c

ALSA: cs4236: fix error return comparison of an unsigned integer

2020-01-09 10:17:56 +01:00

Makefile

…