malhuda/msm-4.14
1
0
Fork 0
mirror of https://github.com/rd-stuffs/msm-4.14.git synced 2025-02-20 11:45:48 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity
msm-4.14/fs
History
Ritesh Harjani c65024b376 ext4: check for non-zero journal inum in ext4_calculate_overhead 
commit f1eec3b0d0a849996ebee733b053efa71803dad5 upstream.

While calculating overhead for internal journal, also check
that j_inum shouldn't be 0. Otherwise we get below error with
xfstests generic/050 with external journal (XXX_LOGDEV config) enabled.

It could be simply reproduced with loop device with an external journal
and marking blockdev as RO before mounting.

[ 3337.146838] EXT4-fs error (device pmem1p2): ext4_get_journal_inode:4634: comm mount: inode #0: comm mount: iget: illegal inode #
------------[ cut here ]------------
generic_make_request: Trying to write to read-only block-device pmem1p2 (partno 2)
WARNING: CPU: 107 PID: 115347 at block/blk-core.c:788 generic_make_request_checks+0x6b4/0x7d0
CPU: 107 PID: 115347 Comm: mount Tainted: G             L   --------- -t - 4.18.0-167.el8.ppc64le #1
NIP:  c0000000006f6d44 LR: c0000000006f6d40 CTR: 0000000030041dd4
<...>
NIP [c0000000006f6d44] generic_make_request_checks+0x6b4/0x7d0
LR [c0000000006f6d40] generic_make_request_checks+0x6b0/0x7d0
<...>
Call Trace:
generic_make_request_checks+0x6b0/0x7d0 (unreliable)
generic_make_request+0x3c/0x420
submit_bio+0xd8/0x200
submit_bh_wbc+0x1e8/0x250
__sync_dirty_buffer+0xd0/0x210
ext4_commit_super+0x310/0x420 [ext4]
__ext4_error+0xa4/0x1e0 [ext4]
__ext4_iget+0x388/0xe10 [ext4]
ext4_get_journal_inode+0x40/0x150 [ext4]
ext4_calculate_overhead+0x5a8/0x610 [ext4]
ext4_fill_super+0x3188/0x3260 [ext4]
mount_bdev+0x778/0x8f0
ext4_mount+0x28/0x50 [ext4]
mount_fs+0x74/0x230
vfs_kern_mount.part.6+0x6c/0x250
do_mount+0x2fc/0x1280
sys_mount+0x158/0x180
system_call+0x5c/0x70
EXT4-fs (pmem1p2): no journal found
EXT4-fs (pmem1p2): can't get journal size
EXT4-fs (pmem1p2): mounted filesystem without journal. Opts: dax,norecovery

Fixes: 3c816ded78bb ("ext4: use journal inode to determine journal overhead")
Reported-by: Harish Sriram <harish@linux.ibm.com>
Signed-off-by: Ritesh Harjani <riteshh@linux.ibm.com>
Reviewed-by: Jan Kara <jack@suse.cz>
Link: https://lore.kernel.org/r/20200316093038.25485-1-riteshh@linux.ibm.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2020-05-02 17:24:46 +02:00
..
9p
9p: avoid attaching writeback_fid on mmap with type PRIVATE
2019-10-11 18:18:38 +02:00
adfs
fs/adfs: super: fix use-after-free bug
2019-08-06 19:05:21 +02:00
affs
affs: fix a memory leak in affs_remount
2020-01-27 14:46:52 +01:00
afs
afs: Fix some tracing details
2020-04-02 16:34:33 +02:00
autofs4
autofs: fix a leak in autofs_expire_indirect()
2019-12-17 20:37:24 +01:00
befs
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
bfs
bfs: add sanity check at bfs_fill_super()
2018-12-01 09:42:51 +01:00
btrfs
btrfs: check commit root generation in should_ignore_root
2020-04-24 08:00:56 +02:00
cachefiles
fscache, cachefiles: remove redundant variable 'cache'
2018-12-17 09:28:53 +01:00
ceph
ceph: don't skip updating wanted caps when cap is stale
2020-05-02 17:24:13 +02:00
cifs
CIFS: Fix bug which the return value by asynchronous read is error
2020-04-24 08:00:40 +02:00
coda
coda: add error handling for fget
2019-08-06 19:05:23 +02:00
configfs
configfs: fix a deadlock in configfs_symlink()
2019-11-12 19:18:18 +01:00
cramfs
Cramfs: fix abad comparison when wrap-arounds occur
2018-11-13 11:15:12 -08:00
crypto
fscrypt: clean up some BUG_ON()s in block encryption/decryption
2019-07-31 07:28:22 +02:00
debugfs
debugfs: fix use-after-free on symlink traversal
2019-05-08 07:20:49 +02:00
devpts
fs/devpts: always delete dcache dentry-s in dput()
2019-03-23 14:35:21 +01:00
dlm
dlm: fix invalid cluster name warning
2019-12-17 20:38:33 +01:00
ecryptfs
ecryptfs: Fix up bad backport of fe2e082f5da5b4a0a92ae32978f81507ef37ec66
2020-03-11 18:02:51 +01:00
efivarfs
…
efs
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
exofs
exofs_mount(): fix leaks on failure exits
2019-12-05 15:37:28 +01:00
exportfs
exportfs: fix 'passing zero to ERR_PTR()' warning
2020-01-27 14:46:06 +01:00
ext2
ext2: fix debug reference to ext2_xattr_cache
2020-04-24 08:01:22 +02:00
ext4
ext4: check for non-zero journal inum in ext4_calculate_overhead
2020-05-02 17:24:46 +02:00
f2fs
f2fs: fix memleak of kobject
2020-02-28 16:36:05 +01:00
fat
fat: fix uninit-memory access for partial initialized inode
2020-03-11 18:03:03 +01:00
freevxfs
…
fscache
fscache: fix race between enablement and dropping of object
2018-12-17 09:28:53 +01:00
fuse
fuse: verify attributes
2019-12-17 20:38:44 +01:00
gfs2
gfs2: Don't demote a glock until its revokes are written
2020-04-24 08:00:27 +02:00
hfs
fs/hfs/extent.c: fix array out of bounds read of array extent
2019-12-01 09:13:57 +01:00
hfsplus
hfsplus: fix crash and filesystem corruption when deleting files
2020-04-24 08:00:45 +02:00
hostfs
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
hpfs
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
hugetlbfs
hugetlb: use same fault hash key for shared and private mappings
2019-05-31 06:47:12 -07:00
isofs
isofs: reject hardware sector size > 2048 bytes
2018-10-03 17:00:57 -07:00
jbd2
jbd2: improve comments about freeing data buffers whose page mapping is NULL
2020-04-24 08:00:54 +02:00
jffs2
jffs2: fix use-after-free on symlink traversal
2019-05-08 07:20:49 +02:00
jfs
jfs: fix bogus variable self-initialization
2020-01-27 14:46:26 +01:00
kernfs
kernfs: fix ino wrap-around detection
2019-12-17 20:38:50 +01:00
lockd
lockd: fix decoding of TEST results
2019-12-17 20:38:15 +01:00
minix
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
ncpfs
staging: ncpfs: memory corruption in ncp_read_kernel()
2018-03-28 18:24:43 +02:00
nfs
NFS: Fix memory leaks in nfs_pageio_stop_mirroring()
2020-04-24 08:01:21 +02:00
nfs_common
lockd: fix "list_add double add" caused by legacy signal interface
2018-02-03 17:39:08 +01:00
nfsd
nfsd: memory corruption in nfsd4_lock()
2020-05-02 17:24:41 +02:00
nilfs2
do d_instantiate/unlock_new_inode combinations safely
2018-05-30 07:51:47 +02:00
nls
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
notify
fs: avoid softlockups in s_inodes iterators
2020-01-12 12:11:59 +01:00
ntfs
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
ocfs2
ocfs2: no need try to truncate file beyond i_size
2020-04-24 08:00:43 +02:00
omfs
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
openpromfs
…
orangefs
help_next should increase position index
2020-02-28 16:36:08 +01:00
overlayfs
ovl: relax WARN_ON() on rename to self
2019-12-17 20:39:21 +01:00
proc
vmalloc: fix remap_vmalloc_range() bounds checks
2020-05-02 17:24:21 +02:00
pstore
pstore/ram: Write new dumps to start of recycled zones
2020-01-09 10:17:55 +01:00
qnx4
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
qnx6
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
quota
fs: avoid softlockups in s_inodes iterators
2020-01-12 12:11:59 +01:00
ramfs
mm: make pagevec_lookup() update index
2017-09-06 17:27:26 -07:00
reiserfs
reiserfs: prevent NULL pointer dereference in reiserfs_insert_item()
2020-02-28 16:36:08 +01:00
romfs
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
squashfs
Squashfs: Compute expected length from inode size rather than block length
2018-09-05 09:26:32 +02:00
sysfs
scsi: sysfs: Introduce sysfs_{un,}break_active_protection()
2018-09-05 09:26:41 +02:00
sysv
sysv: return 'err' instead of 0 in __sysv_write_inode
2018-12-17 09:28:48 +01:00
tracefs
…
ubifs
ubifs: don't trigger assertion on invalid no-key filename
2020-02-14 16:32:11 -05:00
udf
udf: Fix free space reporting for metadata and virtual partitions
2020-02-28 16:36:02 +01:00
ufs
ufs: fix braino in ufs_get_inode_gid() for solaris UFS flavour
2019-05-25 18:25:36 +02:00
xfs
xfs: fix partially uninitialized structure in xfs_reflink_remap_extent
2020-05-02 17:24:43 +02:00
aio.c
aio: fix spectre gadget in lookup_ioctx
2018-12-21 14:13:04 +01:00
anon_inodes.c
…
attr.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
bad_inode.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
binfmt_aout.c
…
binfmt_elf_fdpic.c
Merge branch 'work.set_fs' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2017-09-14 18:13:32 -07:00
binfmt_elf.c
binfmt_elf: Do not move brk for INTERP-less ET_EXEC
2019-10-05 12:48:06 +02:00
binfmt_em86.c
…
binfmt_flat.c
fs/binfmt_flat.c: make load_flat_shared_library() work
2019-07-03 13:15:59 +02:00
binfmt_misc.c
fs/binfmt_misc.c: do not allow offset overflow
2018-06-26 08:06:33 +08:00
binfmt_script.c
exec: load_script: Do not exec truncated interpreter path
2019-11-06 12:42:59 +01:00
block_dev.c
block: fix the return errno for direct IO
2019-04-17 08:37:53 +02:00
buffer.c
ext4: use non-movable memory for superblock readahead
2020-04-24 08:01:00 +02:00
char_dev.c
chardev: Avoid potential use-after-free in 'chrdev_open()'
2020-01-14 20:05:39 +01:00
compat_binfmt_elf.c
…
compat_ioctl.c
fix compat handling of FICLONERANGE, FIDEDUPERANGE and FS_IOC_FIEMAP
2020-01-09 10:17:58 +01:00
compat.c
…
coredump.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
dax.c
dax: pass NOWAIT flag to iomap_apply
2020-03-11 18:02:43 +01:00
dcache.c
fs/dcache: Fix incorrect nr_dentry_unused accounting in shrink_dcache_sb()
2019-02-06 17:31:34 +01:00
dcookies.c
…
direct-io.c
iomap: report collisions between directio and buffered writes to userspace
2019-04-27 09:35:41 +02:00
drop_caches.c
fs: avoid softlockups in s_inodes iterators
2020-01-12 12:11:59 +01:00
eventfd.c
…
eventpoll.c
fs/epoll: drop ovflist branch prediction
2019-02-12 19:46:10 +01:00
exec.c
signal: Extend exec_id to 64bits
2020-04-24 08:00:38 +02:00
fcntl.c
fcntl: don't cap l_start and l_end values for F_GETLK64 in compat syscall
2017-12-17 15:07:59 +01:00
fhandle.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
file_table.c
…
file.c
fs/file.c: initialize init_files.resize_wait
2019-04-05 22:31:28 +02:00
filesystems.c
fs/filesystems.c: downgrade user-reachable WARN_ONCE() to pr_warn_once()
2020-04-24 08:00:43 +02:00
fs_pin.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
fs_struct.c
…
fs-writeback.c
cgroup,writeback: don't switch wbs immediately on dead wbs if the memcg is dead
2019-11-12 19:18:47 +01:00
inode.c
futex: Fix inode life-time issue
2020-04-02 16:34:21 +02:00
internal.h
Merge branch 'overlayfs-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/vfs
2017-09-13 09:11:44 -07:00
ioctl.c
vfs: swap names of {do,vfs}_clone_file_range()
2018-11-10 07:48:33 -08:00
iomap.c
iomap: Fix pipe page leakage during splicing
2019-12-17 20:38:57 +01:00
Kconfig
…
Kconfig.binfmt
…
libfs.c
libfs: fix infoleak in simple_attr_read()
2020-04-02 16:34:35 +02:00
locks.c
locks: print unsigned ino in /proc/locks
2020-01-09 10:17:55 +01:00
Makefile
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
mbcache.c
mbcache: initialize entry->e_referenced in mb_cache_entry_create()
2018-02-22 15:42:25 +01:00
mount.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
mpage.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
namei.c
namei: only return -ECHILD from follow_dotdot_rcu()
2020-03-11 18:02:53 +01:00
namespace.c
fs/namespace.c: fix mountpoint reference counter race
2020-05-02 17:24:20 +02:00
no-block.c
…
nsfs.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
open.c
cifs_atomic_open(): fix double-put on late allocation failure
2020-03-20 10:54:16 +01:00
pipe.c
fs: prevent page refcount overflow in pipe_buf_get
2019-05-04 09:15:18 +02:00
pnode.c
…
pnode.h
…
posix_acl.c
…
proc_namespace.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
read_write.c
vfs: avoid problematic remapping requests into partial EOF block
2019-12-01 09:13:51 +01:00
readdir.c
filldir[64]: remove WARN_ON_ONCE() for bad directory entries
2020-01-04 14:00:04 +01:00
select.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
seq_file.c
seq_file: fix incomplete reset on read from zero offset
2018-02-22 15:42:28 +01:00
signalfd.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
splice.c
fs: prevent page refcount overflow in pipe_buf_get
2019-05-04 09:15:18 +02:00
stack.c
…
stat.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
statfs.c
vfs: Fix EOVERFLOW testing in put_compat_statfs64
2019-10-11 18:18:48 +02:00
super.c
fs: don't scan the inode cache before SB_BORN is set
2018-05-30 07:51:47 +02:00
sync.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
timerfd.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
userfaultfd.c
userfaultfd: require CAP_SYS_PTRACE for UFFD_FEATURE_EVENT_FORK
2020-01-04 13:59:58 +01:00
utimes.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
xattr.c
sysfs: Do not return POSIX ACL xattrs via listxattr
2018-10-10 08:54:27 +02:00