Nick Piggin
d599e36a9e
inotify: fix race
...
There is a race between setting an inode's children's "parent watched" flag
when placing the first watch on a parent, and instantiating new children of
that parent: a child could miss having its flags set by
set_dentry_child_flags, but then inotify_d_instantiate might still see
!inotify_inode_watched.
The solution is to set_dentry_child_flags after adding the watch. Locking is
taken care of, because both set_dentry_child_flags and inotify_d_instantiate
hold dcache_lock and child->d_locks.
Signed-off-by: Nick Piggin <npiggin@suse.de>
Cc: Robert Love <rlove@google.com>
Cc: John McCutchan <ttb@tentacle.dhs.org>
Cc: Jan Kara <jack@ucw.cz>
Cc: Yan Zheng <yanzheng@21cn.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2008-02-06 10:41:06 -08:00
..
2007-11-06 08:02:53 -06:00
2007-10-17 08:42:45 -07:00
2007-10-17 08:42:47 -07:00
2008-01-28 23:58:27 -05:00
2007-10-19 11:53:43 -07:00
2007-10-19 11:53:37 -07:00
2008-02-03 17:33:42 +02:00
2007-12-05 09:25:20 -08:00
2008-02-05 09:44:13 -08:00
2008-01-24 20:40:05 -08:00
2008-01-25 15:05:47 -08:00
2007-10-18 14:37:29 -07:00
2008-01-24 20:40:40 -08:00
2008-01-30 11:04:43 -06:00
2008-02-05 09:44:13 -08:00
2007-10-22 08:13:21 -07:00
2007-10-22 08:13:21 -07:00
2008-02-06 10:41:00 -08:00
2008-02-05 09:44:13 -08:00
2008-02-05 09:44:13 -08:00
2008-02-06 10:41:02 -08:00
2008-02-03 17:33:42 +02:00
2008-01-24 20:40:40 -08:00
2008-02-05 09:44:13 -08:00
2008-02-06 10:41:05 -08:00
2007-10-17 08:42:45 -07:00
2008-02-05 09:44:30 -08:00
2007-10-17 08:42:45 -07:00
2008-02-05 09:44:14 -08:00
2007-10-22 08:13:21 -07:00
2008-01-30 13:31:20 +01:00
2008-01-30 13:31:20 +01:00
2008-02-03 15:14:02 +02:00
2008-02-03 15:42:53 +02:00
2008-02-01 16:42:15 -05:00
2007-10-17 08:42:53 -07:00
2008-02-06 10:41:05 -08:00
2008-02-05 09:44:13 -08:00
2008-02-05 09:44:20 -08:00
2007-10-18 14:37:31 -07:00
2008-02-05 09:44:14 -08:00
2008-02-05 09:44:13 -08:00
2008-01-22 18:29:20 -08:00
2008-01-24 20:40:40 -08:00
2008-02-06 10:41:04 -08:00
2007-10-17 08:42:45 -07:00
2007-10-17 08:42:56 -07:00
2008-02-06 10:41:05 -08:00
2007-10-17 08:42:47 -07:00
2008-02-06 10:41:02 -08:00
2008-01-25 17:19:08 -08:00
2007-10-17 08:42:45 -07:00
2007-10-17 08:43:00 -07:00
2007-12-05 09:21:18 -08:00
2008-02-05 09:44:14 -08:00
2008-01-30 13:31:17 +01:00
2007-10-17 08:43:00 -07:00
2007-10-18 14:37:22 -07:00
2007-12-20 07:49:53 -08:00
2007-10-19 11:53:40 -07:00
2008-02-03 18:05:15 +02:00
2007-10-19 23:21:04 +02:00
2007-10-17 08:42:54 -07:00
2007-10-19 23:21:04 +02:00
2007-10-19 23:21:04 +02:00
2007-10-17 08:42:50 -07:00
2008-01-28 10:04:46 +01:00
2008-02-06 10:41:06 -08:00
2008-02-05 09:44:14 -08:00
2008-01-24 20:40:38 -08:00
2008-01-30 13:31:46 +01:00
2008-01-28 23:21:18 +01:00
2008-02-06 10:41:03 -08:00
2008-02-06 10:41:04 -08:00
2008-02-05 09:44:13 -08:00
2007-12-23 12:54:36 -08:00
2008-02-06 10:41:03 -08:00
2008-02-05 09:44:07 -08:00
2008-02-05 09:44:07 -08:00
2007-10-19 11:53:40 -07:00
2007-10-19 11:53:38 -07:00
2008-02-06 10:41:06 -08:00
2008-02-06 10:41:05 -08:00
2008-01-28 23:58:27 -05:00
2008-02-06 10:41:00 -08:00
2008-02-06 10:41:06 -08:00
2008-01-28 11:38:15 +01:00
2008-02-05 14:37:15 -08:00
2008-01-30 13:31:46 +01:00
2008-02-05 09:44:13 -08:00
2008-02-03 17:51:36 -05:00
2008-01-30 13:31:46 +01:00
2007-10-25 15:18:29 -07:00
2008-02-05 09:44:13 -08:00
2008-02-06 10:41:05 -08:00
2008-01-24 20:40:13 -08:00
2007-11-14 18:45:42 -08:00
2007-10-15 17:00:19 +02:00
2008-02-06 10:41:02 -08:00
2007-10-21 02:37:25 -04:00
2008-01-28 23:58:27 -05:00
2007-12-06 17:39:54 -05:00
2007-10-19 11:53:41 -07:00
2007-10-10 16:55:33 -07:00
2008-02-06 10:41:03 -08:00
2008-02-01 09:26:32 +01:00
2007-10-19 23:21:04 +02:00
2008-02-05 09:44:07 -08:00
2008-02-06 10:41:03 -08:00
2008-02-05 09:44:20 -08:00