mirror of
https://github.com/rd-stuffs/msm-4.14.git
synced 2025-02-20 11:45:48 +08:00
commit e7cdf5c82f1773c3386b93bbcf13b9bfff29fa31 upstream. The vk cts test: dEQP-VK.api.external.semaphore.opaque_fd.export_multiple_times_temporary triggers a lot of VFS: Close: file count is 0 Dave pointed out that clearing the syncobj->file from drm_syncobj_file_release() was sufficient to silence the test, but that opens a can of worm since we assumed that the syncobj->file was never unset. Stop trying to reuse the same struct file for every fd pointing to the drm_syncobj, and allocate one file for each fd instead. v2: Fixup return handling of drm_syncobj_fd_to_handle v2.1: [airlied: fix possible syncobj ref race] v2.2: [jekstrand: back-port to 4.14] Reported-by: Dave Airlie <airlied@redhat.com> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> Tested-by: Dave Airlie <airlied@redhat.com> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch> Signed-off-by: Dave Airlie <airlied@redhat.com> Signed-off-by: Jason Ekstrand <jason@jlekstrand.net> Tested-by: Clayton Craft <clayton.a.craft@intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
136 lines
3.8 KiB
C
136 lines
3.8 KiB
C
/*
|
|
* Copyright © 2017 Red Hat
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person obtaining a
|
|
* copy of this software and associated documentation files (the "Software"),
|
|
* to deal in the Software without restriction, including without limitation
|
|
* the rights to use, copy, modify, merge, publish, distribute, sublicense,
|
|
* and/or sell copies of the Software, and to permit persons to whom the
|
|
* Software is furnished to do so, subject to the following conditions:
|
|
*
|
|
* The above copyright notice and this permission notice (including the next
|
|
* paragraph) shall be included in all copies or substantial portions of the
|
|
* Software.
|
|
*
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
|
|
* THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
|
|
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
|
|
* IN THE SOFTWARE.
|
|
*
|
|
* Authors:
|
|
*
|
|
*/
|
|
#ifndef __DRM_SYNCOBJ_H__
|
|
#define __DRM_SYNCOBJ_H__
|
|
|
|
#include "linux/dma-fence.h"
|
|
|
|
struct drm_syncobj_cb;
|
|
|
|
/**
|
|
* struct drm_syncobj - sync object.
|
|
*
|
|
* This structure defines a generic sync object which wraps a dma fence.
|
|
*/
|
|
struct drm_syncobj {
|
|
/**
|
|
* @refcount:
|
|
*
|
|
* Reference count of this object.
|
|
*/
|
|
struct kref refcount;
|
|
/**
|
|
* @fence:
|
|
* NULL or a pointer to the fence bound to this object.
|
|
*
|
|
* This field should not be used directly. Use drm_syncobj_fence_get
|
|
* and drm_syncobj_replace_fence instead.
|
|
*/
|
|
struct dma_fence *fence;
|
|
/**
|
|
* @cb_list:
|
|
* List of callbacks to call when the fence gets replaced
|
|
*/
|
|
struct list_head cb_list;
|
|
/**
|
|
* @lock:
|
|
* locks cb_list and write-locks fence.
|
|
*/
|
|
spinlock_t lock;
|
|
};
|
|
|
|
typedef void (*drm_syncobj_func_t)(struct drm_syncobj *syncobj,
|
|
struct drm_syncobj_cb *cb);
|
|
|
|
/**
|
|
* struct drm_syncobj_cb - callback for drm_syncobj_add_callback
|
|
* @node: used by drm_syncob_add_callback to append this struct to
|
|
* syncobj::cb_list
|
|
* @func: drm_syncobj_func_t to call
|
|
*
|
|
* This struct will be initialized by drm_syncobj_add_callback, additional
|
|
* data can be passed along by embedding drm_syncobj_cb in another struct.
|
|
* The callback will get called the next time drm_syncobj_replace_fence is
|
|
* called.
|
|
*/
|
|
struct drm_syncobj_cb {
|
|
struct list_head node;
|
|
drm_syncobj_func_t func;
|
|
};
|
|
|
|
void drm_syncobj_free(struct kref *kref);
|
|
|
|
/**
|
|
* drm_syncobj_get - acquire a syncobj reference
|
|
* @obj: sync object
|
|
*
|
|
* This acquires additional reference to @obj. It is illegal to call this
|
|
* without already holding a reference. No locks required.
|
|
*/
|
|
static inline void
|
|
drm_syncobj_get(struct drm_syncobj *obj)
|
|
{
|
|
kref_get(&obj->refcount);
|
|
}
|
|
|
|
/**
|
|
* drm_syncobj_put - release a reference to a sync object.
|
|
* @obj: sync object.
|
|
*/
|
|
static inline void
|
|
drm_syncobj_put(struct drm_syncobj *obj)
|
|
{
|
|
kref_put(&obj->refcount, drm_syncobj_free);
|
|
}
|
|
|
|
static inline struct dma_fence *
|
|
drm_syncobj_fence_get(struct drm_syncobj *syncobj)
|
|
{
|
|
struct dma_fence *fence;
|
|
|
|
rcu_read_lock();
|
|
fence = dma_fence_get_rcu_safe(&syncobj->fence);
|
|
rcu_read_unlock();
|
|
|
|
return fence;
|
|
}
|
|
|
|
struct drm_syncobj *drm_syncobj_find(struct drm_file *file_private,
|
|
u32 handle);
|
|
void drm_syncobj_add_callback(struct drm_syncobj *syncobj,
|
|
struct drm_syncobj_cb *cb,
|
|
drm_syncobj_func_t func);
|
|
void drm_syncobj_remove_callback(struct drm_syncobj *syncobj,
|
|
struct drm_syncobj_cb *cb);
|
|
void drm_syncobj_replace_fence(struct drm_syncobj *syncobj,
|
|
struct dma_fence *fence);
|
|
int drm_syncobj_find_fence(struct drm_file *file_private,
|
|
u32 handle,
|
|
struct dma_fence **fence);
|
|
void drm_syncobj_free(struct kref *kref);
|
|
|
|
#endif
|