Bob Peterson 13c66d2d2b gfs2: clean up iopen glock mess in gfs2_create_inode ...

[ Upstream commit 2c47c1be51fbded1f7baa2ceaed90f97932f79be ]

Before this patch, gfs2_create_inode had a use-after-free for the
iopen glock in some error paths because it did this:

	gfs2_glock_put(io_gl);
fail_gunlock2:
	if (io_gl)
		clear_bit(GLF_INODE_CREATING, &io_gl->gl_flags);

In some cases, the io_gl was used for create and only had one
reference, so the glock might be freed before the clear_bit().
This patch tries to straighten it out by only jumping to the
error paths where iopen is properly set, and moving the
gfs2_glock_put after the clear_bit.

Signed-off-by: Bob Peterson <rpeterso@redhat.com>
Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

2020-10-01 13:12:30 +02:00

..

acl.c

gfs2: preserve i_mode if __gfs2_set_acl() fails

2017-08-31 07:53:15 -05:00

acl.h

…

aops.c

gfs2: forcibly flush ail to relieve memory pressure

2017-08-10 10:51:03 -05:00

bmap.c

gfs2: take jdata unstuff into account in do_grow

2019-12-05 15:37:32 +01:00

bmap.h

…

dentry.c

…

dir.c

We've got a whopping 29 GFS2 patches for this merge window, mainly

2017-09-06 11:42:31 -07:00

dir.h

…

export.c

…

file.c

gfs2: Fix fallocate chunk size

2018-05-30 07:52:35 +02:00

gfs2.h

…

glock.c

Revert "gfs2: Don't demote a glock until its revokes are written"

2020-05-27 16:43:10 +02:00

glock.h

gfs2: gfs2_evict_inode: Put glocks asynchronously

2017-08-10 10:45:21 -05:00

glops.c

gfs2: initialize transaction tr_ailX_lists earlier

2020-09-23 10:46:33 +02:00

glops.h

…

incore.h

gfs2: Silence gcc format-truncation warning

2017-08-25 10:59:21 -05:00

inode.c

gfs2: clean up iopen glock mess in gfs2_create_inode

2020-10-01 13:12:30 +02:00

inode.h

…

Kconfig

…

lock_dlm.c

gfs2: Fix sign extension bug in gfs2_update_stats

2019-05-31 06:47:11 -07:00

log.c

gfs2: initialize transaction tr_ailX_lists earlier

2020-09-23 10:46:33 +02:00

log.h

gfs2: fix glock reference problem in gfs2_trans_remove_revoke

2019-12-17 20:40:01 +01:00

lops.c

gfs2: fix glock reference problem in gfs2_trans_remove_revoke

2019-12-17 20:40:01 +01:00

lops.h

…

main.c

…

Makefile

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

meta_io.c

Merge branch 'for-4.14/block' of git://git.kernel.dk/linux-block

2017-09-07 11:59:42 -07:00

meta_io.h

…

ops_fstype.c

gfs2: read-only mounts should grab the sd_freeze_gl glock

2020-07-22 09:22:21 +02:00

quota.c

gfs2: move privileged user check to gfs2_quota_lock_check

2020-06-03 08:17:52 +02:00

quota.h

gfs2: move privileged user check to gfs2_quota_lock_check

2020-06-03 08:17:52 +02:00

recovery.c

VFS: Convert sb->s_flags & MS_RDONLY to sb_rdonly(sb)

2017-07-17 08:45:34 +01:00

recovery.h

…

rgrp.c

gfs2: Fix marking bitmaps non-full

2019-12-01 09:13:17 +01:00

rgrp.h

…

super.c

GFS2: Flush the GFS2 delete workqueue before stopping the kernel threads

2019-11-24 08:23:25 +01:00

super.h

…

sys.c

VFS: Convert sb->s_flags & MS_RDONLY to sb_rdonly(sb)

2017-07-17 08:45:34 +01:00

sys.h

…

trace_gfs2.h

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

trans.c

gfs2: initialize transaction tr_ailX_lists earlier

2020-09-23 10:46:33 +02:00

trans.h

…

util.c

…

util.h

GFS2: Fix up some sparse warnings

2017-08-25 18:47:18 -05:00

xattr.c

gfs2: don't return ENODATA in __gfs2_xattr_set unless replacing

2017-08-31 07:43:03 -05:00

xattr.h

…