Geert Uytterhoeven 8e0b557782 of: Fix truncation of memory sizes on 32-bit platforms ...

[ Upstream commit 2892d8a00d23d511a0591ac4b2ff3f050ae1f004 ]

Variable "size" has type "phys_addr_t", which can be either 32-bit or
64-bit on 32-bit systems, while "unsigned long" is always 32-bit on
32-bit systems.  Hence the cast in

    (unsigned long)size / SZ_1M

may truncate a 64-bit size to 32-bit, as casts have a higher operator
precedence than divisions.

Fix this by inverting the order of the cast and division, which should
be safe for memory blocks smaller than 4 PiB.  Note that the division is
actually a shift, as SZ_1M is a power-of-two constant, hence there is no
need to use div_u64().

While at it, use "%lu" to format "unsigned long".

Fixes: e8d9d1f5485b52ec ("drivers: of: add initialization code for static reserved memory")
Fixes: 3f0c8206644836e4 ("drivers: of: add initialization code for dynamic reserved memory")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Acked-by: Marek Szyprowski <m.szyprowski@samsung.com>
Link: https://lore.kernel.org/r/4a1117e72d13d26126f57be034c20dac02f1e915.1623835273.git.geert+renesas@glider.be
Signed-off-by: Rob Herring <robh@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

2021-07-20 16:17:40 +02:00

..

unittest-data

…

address.c

of/address: Fix of_node memory leak in of_dma_is_coherent

2020-11-18 18:27:57 +01:00

base.c

of: fix missing kobject init for !SYSFS && OF_DYNAMIC config

2020-04-24 08:01:13 +02:00

device.c

…

dynamic.c

…

fdt_address.c

…

fdt.c

of: Fix truncation of memory sizes on 32-bit platforms

2021-07-20 16:17:40 +02:00

irq.c

…

Kconfig

of: Add OF_DMA_DEFAULT_COHERENT & select it on powerpc

2020-02-14 16:32:13 -05:00

Makefile

…

of_mdio.c

of: of_mdio: Correct loop scanning logic

2020-07-22 09:22:23 +02:00

of_net.c

…

of_numa.c

…

of_pci_irq.c

…

of_pci.c

…

of_private.h

…

of_reserved_mem.c

of: Fix truncation of memory sizes on 32-bit platforms

2021-07-20 16:17:40 +02:00

overlay.c

…

pdt.c

…

platform.c

…

property.c

…

resolver.c

…

unittest.c

of: unittest: kmemleak in of_unittest_platform_populate()

2020-04-24 08:01:17 +02:00