Madhuparna Bhowmik
c3ddd6c130
drivers: watchdog: rdc321x_wdt: Fix race condition bugs ...
[ Upstream commit 4b2e7f99cdd314263c9d172bc17193b8b6bba463 ]
In rdc321x_wdt_probe(), rdc321x_wdt_device.queue is initialized
after misc_register(), hence if ioctl is called before its
initialization which can call rdc321x_wdt_start() function,
it will see an uninitialized value of rdc321x_wdt_device.queue,
hence initialize it before misc_register().
Also, rdc321x_wdt_device.default_ticks is accessed in reset()
function called from write callback, thus initialize it before
misc_register().
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Madhuparna Bhowmik <madhuparnabhowmik10@gmail.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Link: https://lore.kernel.org/r/20200807112902.28764-1-madhuparnabhowmik10@gmail.com
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Wim Van Sebroeck <wim@linux-watchdog.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2020-11-05 11:06:57 +01:00
2018-05-30 07:52:36 +02:00
2019-12-17 20:39:24 +01:00
2015-09-11 15:12:59 -07:00
2015-09-09 21:38:52 +02:00
2015-09-09 21:38:29 +02:00
2016-10-05 18:36:18 -04:00
2017-02-24 14:00:23 -08:00
2017-07-03 13:53:28 +02:00
2019-09-06 10:20:47 +02:00
2017-09-09 20:52:13 +02:00
2017-05-19 10:42:25 +02:00
2017-02-24 14:00:23 -08:00
2017-09-09 20:35:31 +02:00
2017-09-09 20:06:38 +02:00
2017-04-20 12:02:32 +01:00
2016-12-16 06:53:55 -08:00
2017-02-24 14:00:23 -08:00
2017-02-24 14:00:23 -08:00
2020-06-25 15:41:54 +02:00
2018-08-03 07:50:24 +02:00
2018-05-30 07:52:29 +02:00
2017-09-09 20:29:53 +02:00
2017-02-24 14:00:23 -08:00
2018-05-30 07:52:32 +02:00
2017-02-24 14:00:23 -08:00
2017-02-24 14:00:23 -08:00
2017-04-20 12:02:32 +01:00
2020-08-21 09:48:19 +02:00
2015-09-28 10:56:01 +02:00
2017-02-24 14:00:23 -08:00
2018-02-16 20:22:44 +01:00
2018-03-15 10:54:22 +01:00
2015-09-09 21:39:22 +02:00
2017-02-24 14:00:23 -08:00
2019-10-11 18:18:35 +02:00
2017-06-05 20:37:35 +02:00
2017-09-09 20:06:25 +02:00
2017-11-02 11:10:55 +01:00
2017-09-09 17:41:24 +02:00
2016-12-16 06:53:54 -08:00
2020-02-05 14:18:06 +00:00
2017-03-01 06:15:10 -08:00
2017-09-04 13:53:15 +02:00
2016-12-16 06:53:55 -08:00
2017-02-24 14:00:23 -08:00
2017-11-02 11:10:55 +01:00
2016-01-31 16:51:56 +01:00
2017-09-09 20:40:39 +02:00
2017-09-09 21:19:58 +02:00
2017-02-24 14:00:23 -08:00
2015-09-09 21:39:22 +02:00
2019-12-05 15:37:03 +01:00
2017-09-09 20:14:01 +02:00
2016-03-01 15:36:35 +01:00
2016-12-16 06:53:55 -08:00
2017-09-09 20:29:53 +02:00
2016-03-01 15:36:35 +01:00
2016-03-01 16:25:39 +01:00
2017-02-24 14:00:23 -08:00
2016-07-17 21:04:13 +02:00
2017-09-04 21:19:03 +02:00
2017-09-04 21:19:03 +02:00
2017-09-09 20:48:18 +02:00
2015-12-27 21:09:40 +01:00
2017-06-05 20:39:12 +02:00
2017-04-20 12:02:32 +01:00
2017-09-09 20:37:36 +02:00
2016-07-17 20:59:23 +02:00
2016-07-25 12:02:32 +02:00
2016-07-25 12:02:43 +02:00
2017-02-24 14:00:23 -08:00
2016-03-16 21:09:42 +01:00
2016-10-08 10:27:13 +02:00
2016-10-08 10:27:17 +02:00
2017-09-09 20:50:35 +02:00
2016-03-01 15:29:42 +01:00
2020-11-05 11:06:57 +01:00
2019-02-12 19:46:03 +01:00
2015-09-09 21:39:22 +02:00
2020-02-05 14:18:06 +00:00
2017-09-09 20:29:53 +02:00
2017-06-05 20:37:17 +02:00
2017-06-05 20:38:52 +02:00
2017-02-24 14:00:23 -08:00
2019-12-05 15:38:19 +01:00
2018-05-30 07:52:10 +02:00
2017-09-09 21:14:46 +02:00
2016-05-14 18:25:56 +02:00
2017-02-24 14:00:23 -08:00
2017-03-01 06:15:10 -08:00
2017-09-09 21:17:44 +02:00
2016-05-14 16:16:04 +02:00
2018-04-26 11:02:08 +02:00
2016-09-24 08:59:49 +02:00
2017-09-09 20:06:31 +02:00
2016-01-11 21:51:28 +01:00
2017-02-24 14:00:23 -08:00
2017-02-24 14:00:23 -08:00
2017-02-24 14:00:23 -08:00
2017-02-24 14:00:23 -08:00
2017-09-09 20:06:14 +02:00
2015-12-28 22:29:35 +01:00
2017-09-04 14:41:02 +01:00
2016-09-23 22:36:32 +02:00
2017-07-03 13:58:55 +02:00
2015-09-09 21:39:22 +02:00
2015-09-09 21:39:22 +02:00
2019-11-24 08:22:57 +01:00
2015-11-23 08:59:30 +01:00
2016-09-23 08:37:14 +02:00
2015-12-29 20:36:01 +01:00
2020-05-27 16:42:50 +02:00
2016-10-08 10:27:24 +02:00
2017-11-02 11:10:55 +01:00
2020-03-11 18:02:48 +01:00
2017-05-18 18:51:44 +02:00
2017-04-20 12:02:32 +01:00
2017-02-24 14:00:23 -08:00
2015-09-09 21:39:22 +02:00
2017-09-09 21:16:17 +02:00
2017-09-09 20:18:43 +02:00
c3ddd6c130