malhuda/CodeIgniter4
1
0
Fork 0
mirror of https://github.com/codeigniter4/CodeIgniter4.git synced 2025-02-20 11:44:28 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Refactoring the actual sending of the request out of send method for testability without sending anything.

Browse Source
This commit is contained in:
Lonnie Ezell 2015-11-18 22:11:44 -06:00
parent fbda1d5b30
commit 181a65d334
1 changed files with 30 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

44
system/HTTP/CURLRequest.php
View File

@ -255,8 +255,6 @@ class CURLRequest extends Request
// Reset our curl options so we're on a fresh slate.
$curl_options = [];
$ch = curl_init();
$curl_options[CURLOPT_URL] = $url;
$curl_options[CURLOPT_RETURNTRANSFER] = true;
$curl_options[CURLOPT_HEADER] = true;
@ -266,18 +264,7 @@ class CURLRequest extends Request
$curl_options = $this->applyMethod($method, $curl_options);
$curl_options = $this->applyRequestHeaders($curl_options);
// Actually apply the curl options
curl_setopt_array($ch, $curl_options);
// Send the request and wait for a response.
$output = curl_exec($ch);
if($output === false)
{
throw new \RuntimeException(curl_errno($ch) .': '. curl_error($ch));
}
curl_close($ch);
$output = $this->sendRequest($curl_options);
// Split out our headers and body
$break = strpos($output, "\r\n\r\n");
@ -483,4 +470,33 @@ class CURLRequest extends Request
//--------------------------------------------------------------------
/**
* Does the actual work of initializing cURL, setting the options,
* and grabbing the output.
*
* @param array $curl_options
*
* @return string
*/
protected function sendRequest(array $curl_options = []): string
{
$ch = curl_init();
curl_setopt_array($ch, $curl_options);
// Send the request and wait for a response.
$output = curl_exec($ch);
if($output === false)
{
throw new \RuntimeException(curl_errno($ch) .': '. curl_error($ch));
}
curl_close($ch);
return $output;
}
//--------------------------------------------------------------------
}