77 Commits

Author SHA1 Message Date
kenjis
7dda3b12e0
chore: remove PHPStan ignored error pattern 2023-06-17 10:11:54 +09:00
kenjis
a4de3e7dab
refactor: remove unneeded code
$this->locale is set in the detectLocale() method called in the constructor.
2023-05-26 09:17:49 +09:00
Marek Mosna
4c6e4ecc25
Fix PostgreSQL getVersion() logic 2023-05-20 09:03:25 +02:00
kenjis
b9157af9e1
chore: remove Ignored error pattern 2023-04-13 10:10:38 +09:00
kenjis
d4e47a3497
chore: remove ignore patterns that are no longer needed 2023-02-22 09:58:53 +09:00
kenjis
0b3460baaa
chore: update phpstan-baseline.neon.dist 2023-01-30 13:58:26 +09:00
kenjis
ad93e936f0
fix: Event collector does not collect Timeline data 2023-01-24 16:09:47 +09:00
Abdul Malik Ikhsan
ee9abc7408
[Rector] Enable AddDefaultValueForUndefinedVariableRector 2023-01-12 17:25:16 +07:00
kenjis
02679aa9fc
chore: update phpstan-baseline for PHPStan 1.9.9 2023-01-12 10:27:54 +09:00
kenjis
1284e73392
Merge remote-tracking branch 'upstream/develop' into 4.3
Conflicts:
	phpstan-baseline.neon.dist
	system/Session/Handlers/DatabaseHandler.php
	system/Test/Mock/MockAppConfig.php
	system/Test/Mock/MockCLIConfig.php
	user_guide_src/source/installation/upgrading.rst
	user_guide_src/source/libraries/sessions.rst
	user_guide_src/source/libraries/sessions/039.php
	user_guide_src/source/libraries/sessions/040.php
	user_guide_src/source/libraries/sessions/041.php
	user_guide_src/source/libraries/sessions/042.php
2022-12-22 13:15:05 +09:00
kenjis
cb6d80161f
fix: format of $proxyIPs
Specify HTTP header name for security reasons.
2022-12-22 02:30:40 +00:00
kenjis
0e4ce5a9e3
Merge remote-tracking branch 'upstream/develop' into 4.3
Conflicts:
	phpstan-baseline.neon.dist
	system/Commands/Utilities/Namespaces.php
2022-12-15 08:57:07 +09:00
kenjis
5a359a0651
refactor: if conditions
$config->psr4, $config->classmap, $config->files are surely defined,
because thay are defined in CodeIgniter\Config\AutoloadConfig.
2022-12-14 17:09:14 +09:00
kenjis
fbb8db40f5
fix: spark namespaces cannot show a namespace with mutilple paths 2022-12-14 17:02:00 +09:00
kenjis
2ad6f5106a
Merge remote-tracking branch 'upstream/develop' into 4.3
Conflicts:
	phpstan-baseline.neon.dist
2022-12-06 10:31:38 +09:00
ping-yee
d5111d5989
change the ignore error of phpstan. 2022-11-19 01:54:06 +08:00
kenjis
03d84e49a4
chore: remove ignoreErrors item
PHPStan 1.9.0 reported:
 ------ ----------------------------------------------------------------------------------------------------------
  Line   system/CLI/Console.php
 ------ ----------------------------------------------------------------------------------------------------------
         Ignored error pattern #^Strict comparison using === between array<mixed, mixed> and array{} will always
         evaluate to false\.$# in path /.../CodeIgniter4/system/CLI/Console.php
         was not matched in reported errors.
 ------ ----------------------------------------------------------------------------------------------------------
2022-11-04 10:25:20 +09:00
John Paul E. Balandan, CPA
9bdce7523c
Add template types to Result 2022-11-01 17:14:33 +08:00
kenjis
118438337e
refactor: CURLRequest extends OutgoingRequest 2022-10-26 17:12:44 +09:00
kenjis
ed1b0fd227
fix: use OutgoingRequestInterface and OutgoingRequest class 2022-10-26 17:12:43 +09:00
John Paul E. Balandan, CPA
62d5cf4a92
Add template types to Connection 2022-10-20 23:07:53 +08:00
kenjis
763a5d94df
Merge remote-tracking branch 'upstream/develop' into 4.3 2022-10-20 16:47:58 +09:00
kenjis
18206b175c
Merge pull request #6721 from kenjis/fix-phpdocs-form_helper
refactor: remove unneeded code in form_helper
2022-10-20 16:46:51 +09:00
kenjis
6fe095a3b7
Merge remote-tracking branch 'upstream/develop' into 4.3 2022-10-20 13:23:19 +09:00
kenjis
3a3afd4314
docs: fix PHPDoc types 2022-10-20 08:47:29 +09:00
kenjis
82bfd12758
fix: add missing abstract methods 2022-10-19 10:53:52 +09:00
John Paul E. Balandan, CPA
64e26f8d6f
Add template types to PreparedQuery 2022-10-18 12:25:05 +08:00
Dyno
2f5bce778a
fix phpstan after rebase 2022-10-17 09:55:50 +02:00
Dyno
dbe460ec9c
fix: do not unset statement after closing it, instead set to null 2022-10-17 09:46:54 +02:00
Dyno
0b6e0e4a9a
refactor: move duplication in the implementations of _close() to the base class 2022-10-17 09:46:52 +02:00
Dyno
344bc6f925
fix: Undefined property: CodeIgniter\Database\OCI8\PreparedQuery::$statement 2022-10-17 09:46:03 +02:00
Dyno
d0df1e2bc7
feat: Abstract method and database dependants versions of the "close" method 2022-10-17 09:42:51 +02:00
kenjis
729f3f1027
Merge remote-tracking branch 'upstream/develop' into 4.3 2022-10-15 21:41:09 +09:00
kenjis
53d1b7957c
chore: update PHPStan PHP version to PHP 8.1 2022-10-12 08:20:48 +09:00
kenjis
a45a796286
chore: update phpstan-baseline.neon.dist for PHPStan 1.8.7
It seems the error message has been changed:
 ------ ----------------------------------------------------------------------------------------------------
  Line   system/CLI/Console.php
 ------ ----------------------------------------------------------------------------------------------------
  71     Strict comparison using === between array<mixed, mixed> and array{} will always evaluate to false.
 ------ ----------------------------------------------------------------------------------------------------
But the $params may be empty array, so it still seems false positive.
2022-10-05 08:36:20 +09:00
Lonnie Ezell
adcfde7ca1
Allow Cells to be auto-located within */Cells directories (#6601)
* Allow Cells to be located in */Cell directories.

* Refactor to use factories.

* Apply suggestions from code review

Co-authored-by: kenjis <kenji.uui@gmail.com>

Co-authored-by: kenjis <kenji.uui@gmail.com>
2022-09-30 08:09:17 -05:00
kenjis
51429cd8db
docs: use @phpstan-ignore-next-line instead of phpstan-baseline 2022-09-06 10:56:13 +09:00
kenjis
428057a684
Merge remote-tracking branch 'upstream/develop' into 4.3
Conflicts:
	phpstan-baseline.neon.dist
2022-09-02 11:20:41 +09:00
kenjis
f9571006bf
chore: remove ignore error patterns
The new version of PHPStan reported:
  Ignored error pattern ... in path ... was not matched in reported errors.
2022-09-02 09:55:08 +09:00
kenjis
0672277706
fix: remove session from Validation 2022-08-21 10:56:20 +09:00
John Paul E. Balandan, CPA
ef360c8a89
Add phpstan error to baseline for now 2022-08-18 10:46:33 +08:00
MGatner
d94e054929
Merge branch 'develop' into 4.3 2022-08-05 14:44:11 +00:00
Abdul Malik Ikhsan
d840ee259f
Merge pull request #6338 from codeigniter4/dependabot/composer/rector/rector-0.13.10
chore(deps-dev): update rector/rector requirement from 0.13.9 to 0.13.10
2022-08-04 08:50:24 +07:00
Abdul Malik Ikhsan
0e598d1cc3
re-run rector with enable RemoveAlwaysTrueIfConditionRector with skip only in trait 2022-08-03 22:53:38 +07:00
kenjis
8fb0e7ee21
refactor: remove unused '(null)' 2022-08-03 08:16:56 +09:00
kenjis
fa8c0f794d
feat: add compatibility with CI3 Encryption 2022-07-22 14:42:01 +09:00
kenjis
ff70de30e7
Merge remote-tracking branch 'upstream/develop' into 4.3 2022-07-14 09:19:56 +09:00
sclubricants
3bddc85bac
Fix create table if not exists when indexes exist 2022-07-12 10:20:09 -07:00
kenjis
a2310baa13
refactor: add type for properties 2022-07-02 18:16:23 +09:00
kenjis
233e8c4b3b
fix: prepared query is executed when using QueryBuilder 2022-06-20 19:11:53 +09:00