malhuda/alice-lg
1
0
Fork 0
Code Issues 39 Pull Requests 11 Actions Packages Projects Releases 2 Wiki Activity

alice.conf: Add some comments about section usage #147

Merged
jof merged 1 commits from jof/describe-config into develop 2024-02-29 17:20:16 +08:00
Conversation 0 Commits 1 Files Changed 1 +6 -3
jof commented 2024-02-23 12:35:35 +08:00 (Migrated from github.com)
Copy Link

I was duplicating a lot of prefixes into [rejection_reasons]. With the BIRD source, this wasn't an issue, but with bgplgd sources which don't show Adj-RIBs-Out data per-peer, the presence of a route in the [rejection_reasons] section actually shows the route as filtered, even though it wasn't actually getting filtered out.

This adds some comments to the sections to describe their use a bit more, in the hopes of preventing this confusion for future alice-lg operators.

I was duplicating a lot of prefixes into `[rejection_reasons]`. With the BIRD source, this wasn't an issue, but with bgplgd sources which don't show Adj-RIBs-Out data per-peer, the presence of a route in the `[rejection_reasons]` section actually shows the route as filtered, even though it wasn't actually getting filtered out. This adds some comments to the sections to describe their use a bit more, in the hopes of preventing this confusion for future alice-lg operators.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working
dependencies
Pull requests that update a dependency file
duplicate
This issue or pull request already exists
enhancement
New feature or request
go
Pull requests that update Go code
good first issue
Good for newcomers
help wanted
Extra attention is needed
invalid
This doesn't seem right
javascript
Pull requests that update Javascript code
priority
question
Further information is requested
wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: malhuda/alice-lg#147
No description provided.
Delete Branch "jof/describe-config"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?