malhuda/alice-lg
1
0
Fork 0
Code Issues 39 Pull Requests 11 Actions Packages Projects Releases 2 Wiki Activity

update GoBGP to v3.26.0 #162

Open
wrgeorge1983 wants to merge 1 commits from wrgeorge1983/161_update_GoBGP into develop
pull from: wrgeorge1983/161_update_GoBGP
merge into: malhuda:develop
Conversation 0 Commits 1 Files Changed 10 +85 -115
wrgeorge1983 commented 2024-05-01 15:50:43 +08:00 (Migrated from github.com)
Copy Link

troubleshooting for #161 made it clear what's actually going on is just need to target the newer release.

With these changes I was able to get GoBGP working

looking at the original go.mod it was targeting v2.4.0 (circa 2019). v3.0.0 came out in 2022.

Since I don't have any detailed knowledge, I assumed "latest is best" and targeted 3.26.0 here, but imagine any other semi-recent releases would work as well.

Most of the changes come down to using "asn" in field names instead of "as" and "ASNumber".

also change to the enum AddPeerMode enum (line 90 pkg/sources/gobgp/apiutil/capability.go) of appears correct (IDE says so!), but I don't know enough Go to be certain.

Let me know if you want any more info or changes!

troubleshooting for #161 made it clear what's actually going on is just need to target the newer release. With these changes I was able to get GoBGP working looking at the original go.mod it was targeting v2.4.0 (circa 2019). v3.0.0 came out in 2022. Since I don't have any detailed knowledge, I assumed "latest is best" and targeted 3.26.0 here, but imagine any other semi-recent releases would work as well. Most of the changes come down to using "asn" in field names instead of "as" and "ASNumber". also change to the enum AddPeerMode enum (line 90 pkg/sources/gobgp/apiutil/capability.go) of appears correct (IDE says so!), but I don't know enough Go to be certain. Let me know if you want any more info or changes!
This pull request has changes conflicting with the target branch.
  • go.mod
  • go.sum
View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin wrgeorge1983/161_update_GoBGP:wrgeorge1983/161_update_GoBGP
git checkout wrgeorge1983/161_update_GoBGP
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working
dependencies
Pull requests that update a dependency file
duplicate
This issue or pull request already exists
enhancement
New feature or request
go
Pull requests that update Go code
good first issue
Good for newcomers
help wanted
Extra attention is needed
invalid
This doesn't seem right
javascript
Pull requests that update Javascript code
priority
question
Further information is requested
wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: malhuda/alice-lg#162
No description provided.
Delete Branch "wrgeorge1983/161_update_GoBGP"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?